Move debian-specific release templates to a subdirectory #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each of these templates includes a debian-specific approach that doesn't apply to RPMs. The templates remaining in the `templates/release` directory don't appear to be debian-specific and should be usable for RPMs as well. In some locations (such as `release_job.py`) it will be necessary to select a template based on the packaging format of the target OS. Organizing the templates in subdirectories like this will give us an easy way to select the template that serves a specific purpose for a given packaging format. This is why some of the template file names were also renamed to be more neutral.
|
Please keep the order of the nodes in |
dirk-thomas
approved these changes
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each of these templates includes a debian-specific approach that doesn't apply to RPMs. The templates remaining in the
templates/releasedirectory don't appear to be debian-specific and should be usable for RPMs as well.In some locations (such as
release_job.py) it will be necessary to select a template based on the packaging format of the target OS. Organizing the templates in subdirectories like this will give us an easy way to select the template that serves a specific purpose for a given packaging format. This is why some of the template file names were also renamed to be more neutral.Since only the template files are moving, there shouldn't be any problem with the deployed Jenkins jobs getting out-of-sync with the current
masterofros_buildfarmin regard to this change.