Add scripts to build blocked source entries page #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirk-thomas
reviewed
Sep 10, 2019
sloretz
force-pushed
the
blocked-source-entries
branch
from
42c973a to
24fc641
Compare
dirk-thomas
reviewed
Sep 25, 2019
ros_buildfarm/templates/status/blocked_source_entries_page_job.xml.em
Outdated
Show resolved
Hide resolved
dirk-thomas
reviewed
Sep 26, 2019
There was a problem hiding this comment.
It would be good to group the changes in the following commits so that they can be merged without squashing:
- any kind of refactorings in
status_page.py - 1-to-1 copies of existing files (e.g. the templates / files from the blocked releases to the blocked source entries)
- add the new functions to
status_page.py, update copied files, any other kind of changes
sloretz
force-pushed
the
blocked-source-entries
branch
from
6667374 to
b59b1ee
Compare
@dirk-thomas Changes re-grouped ( I made sure
|
dirk-thomas
reviewed
Sep 26, 2019
ros_buildfarm/status_page.py
Outdated
| maintainers[unreleased_repo_name] = {} | ||
| maintainers[unreleased_repo_name].update(pkg_maintainers) | ||
| new_maintainers = dict(_maintainers(prev_distribution, pkg_name)) | ||
| maintainers[unreleased_repo_name].update(new_maintainers) |
There was a problem hiding this comment.
Maybe eliminate the single use var new_maintainers?
There was a problem hiding this comment.
Removed single use variable and squashed into first commit fc9041c .
Refactor get_blocked_releases_info() so logic can be reused by the blocked source entries page. Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
cp ros_buildfarm/templates/status/blocked_releases_page.html.em ros_buildfarm/templates/status/blocked_source_entries_page.html.em cp ros_buildfarm/templates/status/blocked_releases_page_job.xml.em ros_buildfarm/templates/status/blocked_source_entries_page_job.xml.em cp ros_buildfarm/templates/status/blocked_releases_page_task.Dockerfile.em ros_buildfarm/templates/status/blocked_source_entries_page_task.Dockerfile.em cp scripts/status/build_blocked_releases_page.py scripts/status/build_blocked_source_entries_page.py cp scripts/status/generate_blocked_releases_page_job.py scripts/status/generate_blocked_source_entries_page_job.py cp scripts/status/run_blocked_releases_page_job.py scripts/status/run_blocked_source_entries_page_job.py Signed-off-by: Shane Loretz<[email protected]> Signed-off-by: Shane Loretz <[email protected]>
Adds a page that figures out which repos need source entries based on the packages and repos released in the previous rosdistro. Signed-off-by: Shane Loretz<[email protected]> Signed-off-by: Shane Loretz <[email protected]>
sloretz
force-pushed
the
blocked-source-entries
branch
2 times, most recently
from
ea21c99 to
a97ec89
Compare
dirk-thomas
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also somewhat refactors the blocked releases page generation where convenient for code reuse.
This page shows which repositories need source entries, similar to the blocked releases page. The purpose is to determine which repos need to be worked on next for the Noetic release.
Fix Python 2.7 CI