Support expression of dependencies via install list file #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method makes it possible to enumerate dependencies after the dockerfile has already been generated. It leverages xargs to avoid long lines, and allows dockerfile layers to be generated by splitting dependencies between install list files.
nuclearsandwich
approved these changes
Mar 29, 2019
There was a problem hiding this comment.
This makes sense to me as a way to keep our Dockerfiles homogeneous while enabling new functionality. Personally I feel like storing dependencies in a file between builds makes a ton of sense and I'd love to see the existing approaches deprecated unless they have some clear advantage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method makes it possible to enumerate dependencies after the Dockerfile has already been generated. It leverages xargs to avoid long lines, and allows Dockerfile layers to be generated by splitting dependencies between install list files.
Alternative to #605