Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for working with newer Jenkins versions #587

Merged
merged 4 commits into from
Jan 22, 2019
Merged

Updates for working with newer Jenkins versions #587

merged 4 commits into from
Jan 22, 2019

Conversation

nuclearsandwich
Copy link
Contributor

@nuclearsandwich nuclearsandwich commented Nov 1, 2018 •
edited
Loading

Incorporating these changes will require updates to the buildfarm deployment and live Jenkins instance. As I document the process a guide will be available in ros-infrastructure/buildfarm_deployment#207 and the final version will get published to discourse.

Connects to ros-infrastructure/buildfarm_deployment#207

@nuclearsandwich nuclearsandwich self-assigned this Nov 1, 2018
@nuclearsandwich nuclearsandwich mentioned this pull request Nov 1, 2018
Closed
7 tasks
@nuclearsandwich
Copy link
Contributor Author

I've completed a manual sweep of xml template updates resulting from the updated jenkins and plugin versions. Barring the xml version question below this should be all the changes necessary to run on the latest Jenkins LTS with an updated set of plugins.

Because of the new publish-over plugin and the added configuration default in parameterized-trigger I am not sure these changes are backwards compatible with a buildfarm_deployment configuration based on master today.

Common among all updated configs and is the move to xml 1.1 with the updated XML pseudo tag <?xml version='1.1' encoding='UTF-8'?> but I've not found in the ros_buildfarm library where the xml version is set. @dirk-thomas if you have pointers that would be helpful otherwise I'll go exploring until I find it.

@nuclearsandwich nuclearsandwich changed the title WIP: Updates for working with newer Jenkins versions Updates for working with newer Jenkins versions Nov 9, 2018
@nuclearsandwich nuclearsandwich mentioned this pull request Nov 16, 2018
Merged
@nuclearsandwich
Copy link
Contributor Author

Common among all updated configs and is the move to xml 1.1 with the updated XML pseudo tag <?xml version='1.1' encoding='UTF-8'?> but I've not found in the ros_buildfarm library where the xml version is set.

The above comment is still outstanding although it doesn't prevent the buildfarm from operating and I think that can be addressed in a future PR if desired.

@dirk-thomas
Copy link
Member

I don't think this package every generates a XML declaration line. So I assume it either gets prepended in the Python library communicating with Jenkins or on the server side.

@nuclearsandwich nuclearsandwich force-pushed the jenkins-lts-upgrade branch 2 times, most recently from 3222e93 to a23797f Compare December 6, 2018 15:22
@nuclearsandwich
Use size method rather than size property.
ccc3ebb 
Attempts to wortk with script security plugin 1.48.
@nuclearsandwich
Update plugin versions.
ec35fb2 
These updates are automated based on the plugin version changes and
don't take into account structural changes that may occur with
configurations.
@nuclearsandwich
Update for new publish-over plugin.
3b78d5f 
This construct is used in new configs.
@nuclearsandwich
Add config item by default preserving backward-compatible behavior.
084dc6e 
This comes from the 2.35.2 parameterized-trigger plugin.
jenkinsci/parameterized-trigger-plugin#95
@nuclearsandwich nuclearsandwich merged commit 60f966e into master Jan 22, 2019
@nuclearsandwich nuclearsandwich deleted the jenkins-lts-upgrade branch January 22, 2019 19:10
@nuclearsandwich nuclearsandwich restored the jenkins-lts-upgrade branch January 22, 2019 19:10
@nuclearsandwich
Copy link
Contributor Author

Preserving the development branch for a week to allow others to migrate to master (or a release including this PR).

@nuclearsandwich nuclearsandwich deleted the jenkins-lts-upgrade branch January 29, 2019 23:57
@nuclearsandwich nuclearsandwich restored the jenkins-lts-upgrade branch January 30, 2019 00:20
@nuclearsandwich nuclearsandwich deleted the jenkins-lts-upgrade branch June 3, 2019 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas approved these changes

Assignees

@nuclearsandwich nuclearsandwich

Labels
in review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nuclearsandwich @dirk-thomas