use python-rosdistro-modules where possible #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfoote
requested changes
Feb 25, 2017
stdeb.cfg
Outdated
| Depends: python-argparse, python-catkin-pkg-modules, python-configparser, python-empy, python-rosdistro (>= 0.4.0), python-yaml, python3-empy | ||
| Depends3: python3-catkin-pkg-modules, python3-empy, python3-rosdistro (>= 0.4.0), python3-yaml | ||
| Depends: python-argparse, python-catkin-pkg-modules, python-configparser, python-empy, python-rosdistro-modules, python-yaml, python3-empy | ||
| Depends3: python3-catkin-pkg-modules, python3-empy, python3-rosdistro-modules-modules, python3-yaml |
There was a problem hiding this comment.
Great catch. I must have been overly eager with search-and-replace. Thx.
dirk-thomas
force-pushed
the
rosdistro_modules
branch
from
1dbdbbb to
d3c101f
Compare
|
The only usage of any of the scripts provided by rosdistro was the above mentioned |
tfoote
approved these changes
Feb 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #379.
The only location requiring
python3-rosdistroisros_buildfarm/ros_buildfarm/templates/misc/rosdistro_cache_task.Dockerfile.em
Line 35 in ec21874
rosdistro_build_cache.