Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lunar targets #360

Merged
merged 1 commit into from
Jan 11, 2017
Merged

added lunar targets #360

merged 1 commit into from
Jan 11, 2017

Conversation

mikaelarguedas
Copy link
Contributor

I assumed it's ok to have duplicate os_code_mapping values because they're always associated with the os_short_name so it shouldn't be ambiguous. Is that correct ?

@dirk-thomas
Copy link
Member

On the status pages the tooltip of the column will show the long string so that should be ok. The only problem would be if a single ROS distro would span across both Saucy and Stretch since the Jenkins views would get merged. But that is not the case so I think this is good as is.

@tfoote tfoote merged commit 7d21575 into master Jan 11, 2017
@tfoote tfoote deleted the lunar_support branch January 11, 2017 23:05
@tfoote tfoote removed the in review label Jan 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants