Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check if any upstream project is in progress #194

Merged
merged 2 commits into from
Feb 2, 2016

Conversation

dirk-thomas
Copy link
Member

In the following example Jenkins is not honoring the flag to block a build when any of its upstream packages is queued:

The dependencies are as follows:

  • A depends on B, C and D
  • B depends on C
  • C depends on D

The timeline of the events was:

  • D5 got triggered (4:08)
  • D5 finished which triggered A and C
  • C4 starts building (4:47), A waits in the queue (nice)
  • C4 finished which triggered A (already queued) and B
  • A4 starts building (4:54:34) bad
    • since B was already queued and is an upstream project
    • it will fail since the Debian package of the upstream project B has been invalidated, but it can't detect it since all upstream projects are still "green"
  • B3 starts building (4:54:42)
  • B finished which triggered A5
  • A5 starts and finished successfully

While that should be ensured by Jenkins we need to double check for it since Jenkins seems to not do that correctly, see pending tickets related to this:

This patch will ensure that A(4) does not only check the status of the last build result of all upstream project but also consideres if any of them are currently building or are currently queued.

@dirk-thomas dirk-thomas self-assigned this Feb 2, 2016
@tfoote
Copy link
Member

tfoote commented Feb 2, 2016

+1

dirk-thomas added a commit that referenced this pull request Feb 2, 2016
…gress

add check if any upstream project is in progress
@dirk-thomas dirk-thomas merged commit e5af98f into master Feb 2, 2016
@dirk-thomas dirk-thomas deleted the check_upstream_in_progress branch February 2, 2016 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants