Parse --dhcp-host #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a number of tests. There are two tests that are commented out with a TODO. Namely one featuring wildcards in mac addresses, and another one with an ipv6 address. I think the latter should be easy to implement, but if that is only applicable for DHCPv6, which I don't think we have an implementation for, it's maybe not worth implementing. |
reynir
force-pushed
the
conf-dhcp-host
branch
from
f4cb8ec to
7989571
Compare
Merged
reynir
force-pushed
the
conf-dhcp-host
branch
from
7989571 to
3276df0
Compare
|
looks fine to me, should there be a test using the |
The "net:" thing is deprecated and the documentation only uses "set:".
hannesm
reviewed
Dec 12, 2024
|
I pushed a commit that changes some internal naming. The |
hannesm
reviewed
Dec 12, 2024
hannesm
reviewed
Dec 12, 2024
hannesm
reviewed
Dec 12, 2024
hannesm
reviewed
Dec 12, 2024
We should allow non-decimal hex characters in the first byte of a mac address. This also changes one of the tests to trigger this bug.
The set: field assigns a tag while tag: matches with a previously assigned tag.
hannesm
reviewed
Dec 12, 2024
Co-authored-by: Hannes Mehnert <[email protected]>
The net: syntax is a backwards compatible form of set:
hannesm
reviewed
Dec 12, 2024
hannesm
reviewed
Dec 12, 2024
hannesm
reviewed
Dec 12, 2024
hannesm
reviewed
Dec 12, 2024
hannesm
reviewed
Dec 12, 2024
hannesm
reviewed
Dec 12, 2024
Co-authored-by: Hannes Mehnert <[email protected]>
hannesm
reviewed
Dec 12, 2024
Dnsmasq will silently ignore duplicate values for some of the dhcp-host arguments. We will error out and inform the user of this.
hannesm
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the parser is more or less there. I plan on adding tests.
I still don't quite understand how all the values are to be used. We may want to error out on certain values and combinations. Part of the values are for matching a client, some are values to assign to the client. Then we have the
ignoreflag which means we should not handle a client matching - in that case the values to assign have questionable meaning.Dnsmasq uses a function
parse_hex()for parsing mac addresses but alsoid:s if there are any colons in the id value. The function is really obscure, and allows you to write an idid:41------424344:*:*:*:*that, likely due to a safety bug, is the same asid:ABCD----. There's a lot of nonsense in there that I don't think we should support.Mac address parsing could as well be improved. In particular there's no wildcards yet (you can write a mac address "pattern"
00:11:*:*:44:55where the middle two bytes match any value).