more options to parse #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support options mentioned in #16
|
Maybe, if @reynir has some time, could do a review? Thanks a lot. |
A local `ignore_line` was shadowing the outer `ignore_line` which was what we want for parsing comments; so the local `ignore_line` is renamed to `ignore_directive`. lease_time without a 'm', 'h' or similar qualifier should not expect `end_of_input`. All `Angstrom.choice` invocations now receive a `~failure_msg` argument for better error messages.
|
I pushed some changes. About comments, it seems you can have comments at the end of lines as long as there is whitespace immediately before the Otherwise it's not allowed I'm not sure how to adapt the parser for this. I think it's fine to defer that to another PR. |
reynir
approved these changes
Nov 6, 2024
reynir
reviewed
Nov 6, 2024
mirage/unikernel.ml
Outdated
Comment on lines
54
to
59
| let interface = | ||
| let doc = | ||
| Arg.info ~docs:ignored ~doc:"Interface to listen on." [ "interface" ] | ||
| in | ||
| Mirage_runtime.register_arg | ||
| Arg.(value & opt Config_parser.(some (ignore_c "interface")) None doc) |
There was a problem hiding this comment.
Annoyingly this collides with the mirage unix argument --interface /o\
There was a problem hiding this comment.
ok, I'm not sure what to do...
There was a problem hiding this comment.
I guess we can figure out a way to rename the unix interface option
|
fails in CI, I'll push my changes from my laptop in the morning (I did some changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.