Support NO_UPDATE in ActionCable subscriptions #3713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this may be the fix for #3189 and similar empty subscription updates I'm seeing in my application.
Applies the same pattern to
ActionCableSubscriptions
asSubscriptions
, which just checks ifexecute_update
returnsnil
and skips the delivery. Seegraphql-ruby/lib/graphql/subscriptions.rb
Lines 141 to 146 in bace1e4
Given this is a subclass, I'm guessing there's a better way to rely on the superclass behavior and ensure all subclasses inherit this important feature. Open to suggestions.