Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

取得・削除API #126

Merged
merged 17 commits into from
Feb 25, 2025
Merged

取得・削除API #126

merged 17 commits into from
Feb 25, 2025

Conversation

hideyukifujita
Copy link
Collaborator

@hideyukifujita hideyukifujita commented Feb 17, 2025 •
edited
Loading

何卒よろしくお願い申し上げます。

ID指定して一件取得

スクリーンショット 2025-02-17 14 52 43

削除

スクリーンショット 2025-02-17 15 57 19

参考

MockDBを使ってテスト https://github.com/DATA-DOG/go-sqlmock
URLをバインドする https://gin-gonic.com/ja/docs/examples/bind-uri/

@hideyukifujita hideyukifujita added enhancement New feature or request backend golang Go言語 labels Feb 17, 2025
@hideyukifujita hideyukifujita self-assigned this Feb 17, 2025
@hideyukifujita hideyukifujita marked this pull request as ready for review February 17, 2025 06:29
riii111
riii111 reviewed Feb 20, 2025
View reviewed changes
Copy link
Owner

@riii111 riii111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あんまりなかったです。さすがっす！！ 🙌
Deleteを204にしてるのナイスです。

レスポンスのDTOあった方が良い気がしたんですけど、一覧取得の時でもOKです

sotaheavymetal21
sotaheavymetal21 reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@sotaheavymetal21 sotaheavymetal21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

綺麗な実装ありがとうございますd(￣ ￣)
コメント置いときましたです！（テストはまだ見れておりません！🙏）

@riii111 riii111 closed this Feb 20, 2025
@riii111 riii111 reopened this Feb 20, 2025
@hideyukifujita hideyukifujita changed the title 【在庫管理API】削除とID指定して一件取得 , Feb 20, 2025
@hideyukifujita hideyukifujita changed the title , 取得・削除API Feb 21, 2025
yuu0305
yuu0305 reviewed Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@yuu0305 yuu0305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MockDBの設定ありがとうございます、勉強になります🙇‍♂️
取得と削除も特に突っ込むところも見当たらず、、

あとは
テストをおくフォルダも統一したいかなと感じました🦍
(また話し合って決めたいですね)

@yuu0305
Copy link
Collaborator

yuu0305 commented Feb 21, 2025

Rad LGTM

riii111
riii111 approved these changes Feb 21, 2025
View reviewed changes
Copy link
Owner

@riii111 riii111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
外からLGTM！！！

sotaheavymetal21
sotaheavymetal21 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@sotaheavymetal21 sotaheavymetal21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
おつピヨでしたd(￣ ￣)

image

@sotaheavymetal21 sotaheavymetal21 merged commit 7ebd174 into develop Feb 25, 2025
2 checks passed
@sotaheavymetal21 sotaheavymetal21 deleted the feature/#43/delete_stocks branch February 25, 2025 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuu0305 yuu0305 yuu0305 left review comments

@sotaheavymetal21 sotaheavymetal21 sotaheavymetal21 approved these changes

@riii111 riii111 riii111 approved these changes

Assignees

@hideyukifujita hideyukifujita

Labels
backend enhancement New feature or request golang Go言語
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hideyukifujita @yuu0305 @sotaheavymetal21 @riii111