Get rid of the split semantics, use start & len #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the split semantics can help you partition the disk without overlaps it's mostly annoying because you usually either have a pair of start and end (or last) sectors, or a start sector and a length.
mseri
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Mar 21, 2024
CHANGES: - BREAKING disconnect no longer disconnects the underlying block device and instead marks the partition as disconnected. This does not propagate to subpartitions (reynir/mirage-block-partition#9 @dianaoigo) - BREAKING `connect` and `subpartition` no longer return pairs. Instead, `connect` returns a partition representing the whole block device. `subpartition` then takes labelled arguments `~start` and `~len`. While the "split" semantics has some nice properties it does not fit very well with how partitions are specified in partition tables (reynir/mirage-block-partition#13 @reynir) - mirage-block-partition-mbr is simplified and no longer checks for overlapping partitions. The module may be removed or revised in a future release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the split semantics can help you partition the disk without overlaps it's mostly annoying because you usually either have a pair of start and end (or last) sectors, or a start sector and a length.
There is a regression of sorts in mirage-block-partition-mbr as we no longer check for overlapping partitions or partitions that include the MBR itself. It could be added back, but I suspect there are not any users of this code. So maybe better to just remove it altogether?!