[caching] Rewrite d1d5852 fixing #757 #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original change in d1d5852 only addressed java and did so at detriment of all formatters. This caused certain platforms to continually update the cache file on every build. As seen on GitHub, Linux and Macos would change the *nix hashes for every file constantly including java. For Windows on Github, it was changing the entire file (not clear as to why entire file but that was observed over and over). Testing to show issue was done with 2.23.0 formatter release that introduced the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #757
Original change in d1d5852 only addressed java and did so at detriment of all formatters. This caused certain platforms to continually update the cache file on every build. As seen on GitHub, Linux and Macos would change the *nix hashes for every file constantly including java. For Windows on Github, it was changing the entire file (not clear as to why entire file but that was observed over and over). Testing to show issue was done with 2.23.0 formatter release that introduced the problem.