Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An initial tweak of the grouping exercise requirements, based on team feedback #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbatistoni-zl
Copy link

We can go a lot further here, possibly redesigning the exercise entirely, but for now I think this will take care of some common issues we're seeing, namely:

  • Submissions made in a language other than Ruby are frequently harder to assess, even though the rubric says they're fine.
  • Because the instructions are so sparse, there's wide variability in what people do and don't include, as far as documentation and tests goes. The new wording strongly encourages them to consider those things, whilst still leaving them to decide what they "normally provide".

* Only use code that you have license to use
* Your submission should be complete, including the kinds of tests, documentation and other artifacts you'd normally provide as part of a pull request or finished solution.
* Bear in mind that our interviewers will need to run your code to evaluate it, so consider dependencies carefully.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I ran it through AI, any better?

General Instructions:

  • Do not fork this repository when submitting your solution.
  • Your solution must be written in Ruby.
  • Ensure that you have the legal rights to use any code you include in your submission.
  • Your submission should be complete—it should include tests, documentation, and any other artifacts you would typically provide in a production-ready pull request.
  • Our interviewers will need to run your code, so carefully consider dependencies and provide clear setup instructions.
  • If you have any questions or need clarifications, don’t hesitate to reach out.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things come to mind.

  1. Do we have a time limit on this? Or a time recommendation?
  2. When it comes to documentaiton I think a very important skill is documenting deficiencies or areas of improvement. I know there are non-performant ways to solve this problem. If they get a solution that is non-performant but they talk about how it might be improved I feel like that goes a long way and can be a great starting point for the techincal interview.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very true! Most people have full time jobs and I believe we advise them not to spend more than a couple of hours on this. Calling out short comings goes along way for me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants