-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
components as literal vars #4223
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
42b8586
component as literal vars
adhami3310 d8962db
fix pyi
adhami3310 f754b85
use render
adhami3310 67b8eb9
fix pyi
adhami3310 c7a234b
only render once
adhami3310 2786bd5
add type ignore
adhami3310 6698945
fix upload default value
adhami3310 49ab17d
remove testcases if you don't pass them
adhami3310 56b703d
improve behavior
adhami3310 3dacafe
fix render
adhami3310 668e402
that's not how icon buttons work
adhami3310 5c99656
upgrade to next js 15 and remove babel and enable turbo
adhami3310 39bbbd9
upload is a silly guy
adhami3310 2fb0b44
woops
adhami3310 ecaea4c
how did this work before
adhami3310 dc9ce91
merging
adhami3310 35008af
set env variable
adhami3310 d3ec565
lower it even more
adhami3310 5f6e538
lower it even more
adhami3310 867190c
lower it even more
adhami3310 0cede07
merging
adhami3310 923e60f
only do literals as component vars
adhami3310 4bfad2c
merging
adhami3310 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be nice if we could move some of this special specific logic closer to the components that will actually depend on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the current stage there's no standardization of the dict format, so the checks are very tight to what we have right now, i can restructure the rendering logic in the future if needed