Enable cancelling active listeners when unsubscribing #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5acc6ef:
|
size-limit report 📦
|
FaberVitale
suggested changes
Feb 27, 2022
| @@ -478,6 +478,80 @@ describe('createListenerMiddleware', () => { | |||
| expect(effect.mock.calls).toEqual([[testAction1('a'), middlewareApi]]) | |||
| }) | |||
|
|
|||
| test.only('can cancel an active listener when unsubscribing directly', async () => { | |||
There was a problem hiding this comment.
.only should be removed.
There was a problem hiding this comment.
DRAT thank you!
markerikson
force-pushed
the
feature/final-1.8-cleanup
branch
from
8c73422 to
115f950
Compare
FaberVitale
reviewed
Feb 27, 2022
markerikson
force-pushed
the
feature/final-1.8-cleanup
branch
2 times, most recently
from
7f33584 to
6e70057
Compare
FaberVitale
reviewed
Feb 27, 2022
markerikson
force-pushed
the
feature/final-1.8-cleanup
branch
from
6e70057 to
5acc6ef
Compare
|
Awright. Merging, and releasing shortly! |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
removeAllListenersaction creator toclearAllListenersunsubscribecallbacks to optionally accept{cancelActive: true}to cancel active listeners@alphatype labels to be@public