Skip to content

Add missing pipeline params #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2025

Conversation

paulorsousa
Copy link
Collaborator

This PR addresses missing pipeline configurations in memtier_benchmark test suites and adds corresponding non-pipeline variants to ensure comprehensive benchmark coverage.

Changes Made

1. Fix Missing Pipeline Arguments (commit ca08d03)

  • Fixed 7 test suite files that were missing the --pipeline 10 argument despite having "pipeline-10" in their filenames
  • Files affected:
    • memtier_benchmark-3Mkeys-string-get-with-1KiB-values-pipeline-10-*_conns.yml (3 variants)
    • memtier_benchmark-3Mkeys-string-mixed-20-80-with-512B-values-pipeline-10-*_conns.yml (3 variants)
    • memtier_benchmark-3Mkeys-string-mixed-50-50-with-512B-values-with-expiration-pipeline-10-400_conns.yml

2. Add Non-Pipeline Variants (commit 315c85b)

  • Added 3 new test suite files for non-pipeline benchmarks to complement the existing pipeline variants
  • New files:
    • memtier_benchmark-3Mkeys-string-get-with-1KiB-values-400_conns.yml
    • memtier_benchmark-3Mkeys-string-get-with-1KiB-values-40_conns.yml
    • memtier_benchmark-3Mkeys-string-mixed-20-80-with-512B-values-400_conns.yml

requests:
memory: 3g
tested-commands:
- set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get

requests:
memory: 3g
tested-commands:
- set
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get

@fcostaoliveira fcostaoliveira merged commit 1c15717 into redis:main Jun 28, 2025
13 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants