jsonArrpop fails with null return value (#3196) #3206
Merged
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tishun
added a commit
to tishun/lettuce-core
that referenced
this pull request
Mar 10, 2025
* Handle Null values better when working with JSON * Incomplete submit after some refactoring * Sanitize the CI output when running on CI * Plishing * Never submit irrelevant changes in your PR
4 tasks
tishun
added a commit
that referenced
this pull request
Mar 10, 2025
tishun
changed the title
tishun
changed the title
tishun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading a response from the server one or more of the array values, containing JSON data, could be null.
We need to handle that properly by returning a JsonValue that represents a null value.
Closes #3196
Make sure that:
mvn formatter:formattarget. Don’t submit any formatting related changes.