format by hbase-formatter

[atakavci]

Formatted with hbase-formatter settings,
format issue keeps showing up with lots of files. i ll try to fix them gradually.

[tishun]

We may want to apply a method, similar to the one used in Lettuce, that verifies the formatting (as part of the CI pipeline) and allows to format files with a mvn command (e.g. mvn formatter:format)

What do you think @sazzad16 and @atakavci?

[sazzad16]

We had #2495 and #2494. Could be worth checking.

IMO, we should consider increasing line-width to at least 100 (could be even 120).

[atakavci]

agree with automation suggestions. disagree with formatting it all at one shot now.
we should first fix format issues in a planned manner, then add some linter/formatter to pipeline.

IMO, we should consider increasing line-width to at least 100 (could be even 120).

line width is already 100 in hbase-formatter and count me in for something like 120/140 (120 is common i believe)
<setting id="org.eclipse.jdt.core.formatter.lineSplit" value="100"/>

[ggivo]

@atakavci
I think if we merge #4087, it will supersede this one.
At least we need to make sure we use the same code format rules.
Do we still need this one?

[atakavci]

@ggivo closing this one in favor of #4087
lets keep in mind the suggestion from @sazzad16 around line width.
80 might be reasonable for a lot of reasons in the past, but not anymore.