-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV: module configuration changes for CE8 #956
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, just one thing that I was confused about.
content/develop/interact/search-and-query/administration/configuration.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just had some small suggestions to mention config compatibility in RS/RC when linking to the other pages and to change "Redis Enterprise" to "Redis Software".
content/operate/oss_and_stack/stack-with-enterprise/bloom/config.md
Outdated
Show resolved
Hide resolved
content/operate/oss_and_stack/stack-with-enterprise/search/config.md
Outdated
Show resolved
Hide resolved
content/operate/oss_and_stack/stack-with-enterprise/timeseries/config.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/administration/configuration.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/administration/configuration.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/administration/configuration.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/administration/configuration.md
Outdated
Show resolved
Hide resolved
content/develop/interact/search-and-query/administration/configuration.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rachel Elledge <[email protected]>
Co-authored-by: Rachel Elledge <[email protected]>
Thank you, @rrelledge, for the detailed review. Much appreciated! |
content/develop/interact/search-and-query/administration/configuration.md
Outdated
Show resolved
Hide resolved
Thank you for the review, @LiorKogan. |
DOC-4580
Changes are per this PRD.
Reviewers: It's probably best to review the changes in the generated links below, as the source changes involve a lot of hard-to-read tables.
@LiorKogan Please review the probabilistic and time series pages.
@adrianoamaral or @joeywhelan Please review the RQE pages.
@rrelledge Please review the changes I made to the data structure pages under the Products sections.
Everybody else, have at it! :)