Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: module configuration changes for CE8 #956

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Conversation

dwdougherty
Copy link
Collaborator

@dwdougherty dwdougherty commented Dec 5, 2024

DOC-4580

Changes are per this PRD.

Reviewers: It's probably best to review the changes in the generated links below, as the source changes involve a lot of hard-to-read tables.

@LiorKogan Please review the probabilistic and time series pages.

@adrianoamaral or @joeywhelan Please review the RQE pages.

@rrelledge Please review the changes I made to the data structure pages under the Products sections.

Everybody else, have at it! :)

@dwdougherty dwdougherty added do not merge yet CE 8.0 Redis Community Edition 8.0 (future) labels Dec 5, 2024
@dwdougherty dwdougherty self-assigned this Dec 5, 2024
Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, just one thing that I was confused about.

Copy link
Collaborator

@rrelledge rrelledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just had some small suggestions to mention config compatibility in RS/RC when linking to the other pages and to change "Redis Enterprise" to "Redis Software".

@dwdougherty
Copy link
Collaborator Author

Thank you, @rrelledge, for the detailed review. Much appreciated!

@dwdougherty
Copy link
Collaborator Author

Thank you for the review, @LiorKogan.

@dwdougherty dwdougherty merged commit 24c08ac into community-edition-8 Dec 11, 2024
5 checks passed
@dwdougherty dwdougherty deleted the DOC-4580 branch December 11, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CE 8.0 Redis Community Edition 8.0 (future)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants