Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: some corrections for the previous merge... #1211

Merged
merged 3 commits into from
Feb 25, 2025
Merged

DEV: some corrections for the previous merge... #1211

merged 3 commits into from
Feb 25, 2025
+28 −11

Conversation

dwdougherty
Copy link
Collaborator

...that I forgot to commit. These changes were already reviewed, so this just needs tacit approval from one of the writers.

@dwdougherty dwdougherty added dev CE 8.0 Redis Community Edition 8.0 (future) labels Feb 25, 2025
@dwdougherty dwdougherty requested a review from a team February 25, 2025 15:14
@dwdougherty dwdougherty self-assigned this Feb 25, 2025
andy-stark-redis
andy-stark-redis approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tacitly approved :-)

cmilesb
cmilesb approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@cmilesb cmilesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions GitHub Actions
Copy link
Contributor

Staging links:
https://redis.io/docs/staging/DOC-4873/commands/hgetex/
https://redis.io/docs/staging/DOC-4873/commands/hsetex/

@dwdougherty
Copy link
Collaborator Author

Thank you @cmilesb and @andy-stark-redis!

@dwdougherty dwdougherty merged commit a4fa03c into community-edition-8 Feb 25, 2025
5 checks passed
@dwdougherty dwdougherty deleted the DOC-4873 branch February 25, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmilesb cmilesb cmilesb approved these changes

@andy-stark-redis andy-stark-redis andy-stark-redis approved these changes

Assignees

@dwdougherty dwdougherty

Labels
CE 8.0 Redis Community Edition 8.0 (future) dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwdougherty @cmilesb @andy-stark-redis