feat: constify bitwise and shift functions #441
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
approved these changes
Feb 27, 2025
|
just needs changelog |
2 tasks
DaniPopes
force-pushed
the
const-bits
branch
from
8683b02 to
801f7dc
Compare
- Adds `const fn <op>` for all bitwise and, or, xor - Makes `is_zero`, `*shl`, `*shr`, `rotate*`, `count*` const
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
const fn <op>for all bitwise and, or, xoris_zero,*shl,*shr,rotate*,count*constWIP:
is_zeroactually performs worse because we have to manually implement equality, and I cannot get the compiler to generate optimal code. See https://godbolt.org/z/aM1nE1Pfh