Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule requiring imports be sorted #991

Closed
wants to merge 7 commits into from
+69 −0
Closed

Add rule requiring imports be sorted #991

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
706ef20
Add rule requiring imports be sorted
sberrevoets Dec 15, 2016
8df7d26
fixup! Add rule requiring imports be sorted
sberrevoets Dec 21, 2016
cb82773
fixup! fixup! Add rule requiring imports be sorted
sberrevoets Dec 21, 2016
af792c2
fixup! fixup! fixup! Add rule requiring imports be sorted
sberrevoets Dec 21, 2016
7f9e0eb
fixup! fixup! fixup! fixup! Add rule requiring imports be sorted
sberrevoets Dec 21, 2016
8c425c5
fixup! fixup! fixup! fixup! fixup! Add rule requiring imports be sorted
sberrevoets Dec 21, 2016
ed6475f
fixup! fixup! fixup! fixup! fixup! fixup! Add rule requiring imports …
sberrevoets Dec 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! fixup! fixup! fixup! Add rule requiring imports be sorted
@sberrevoets
sberrevoets committed Dec 22, 2016

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 8c425c5f97d610305800208ad221b71c974f2fa4
5 changes: 2 additions & 3 deletions Source/SwiftLintFramework/Rules/SortedImportsRule.swift
View file
Original file line number Diff line number Diff line change
@@ -6,13 +6,12 @@
// Copyright © 2016 Realm. All rights reserved.
//

import Foundation
import SourceKittenFramework

public struct SortedImportsRule: ConfigurationProviderRule, OptInRule {
public var configuration = SeverityConfiguration(.warning)

private let moduleCharacterOffset = "import ".characters.count

public init() {}

public static let description = RuleDescription(
@@ -48,7 +47,7 @@ public struct SortedImportsRule: ConfigurationProviderRule, OptInRule {
return nil
}

let characterOffset = range.location + moduleCharacterOffset
let characterOffset = range.location + moduleStartIndex
let location = Location(file: file, characterOffset: characterOffset)
return StyleViolation(ruleDescription: type(of: self).description,
severity: configuration.severity, location: location)