Adds closure_body_length opt-in rule #2342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because closure bodies should not span too many lines. Implements realm#52. Requires Swift 4.2.
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
==========================================
- Coverage 92.01% 91.88% -0.14%
==========================================
Files 302 304 +2
Lines 15192 15255 +63
==========================================
+ Hits 13979 14017 +38
- Misses 1213 1238 +25
Continue to review full report at Codecov.
|
marcelofabri
reviewed
Aug 8, 2018
CHANGELOG.md
Outdated
| @@ -9,6 +9,11 @@ | |||
| * Improve performance of `line_length` rule. | |||
| [Marcelo Fabri](https://github.com/marcelofabri) | |||
|
|
|||
| * Add `closure_body_length` rule to enforce the maximum number | |||
There was a problem hiding this comment.
Can you please mention that the rule is opt-in?
There was a problem hiding this comment.
Of course :-) Sorry about that.
explaining closure_body_length is a opt-in rule.
marcelofabri
approved these changes
Aug 9, 2018
|
Thanks @ornithocoder 🎉 |
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because closure bodies should not span too many lines.