[Abandoned] Adds closure_body_length opt-in rule #1747
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
+ Coverage 88.26% 88.34% +0.07%
==========================================
Files 227 229 +2
Lines 11218 11291 +73
==========================================
+ Hits 9902 9975 +73
Misses 1316 1316
Continue to review full report at Codecov.
|
ornithocoder
force-pushed
the
issue_52
branch
2 times, most recently
from
c4dd40f to
4906ecd
Compare
|
I'm having problems to find the exact number of lines. The Update 1: Issue created to discuss the problem with the valid number of code (#1750) |
ornithocoder
force-pushed
the
issue_52
branch
4 times, most recently
from
d1626c8 to
5b160c3
Compare
ornithocoder
changed the title
| let reason = "Closure body should span \(configuration.warning) lines or less " + | ||
| "excluding comments and whitespace: currently spans \(lineCount) " + "lines" | ||
| let closuresAsArgument = dictionary.substructure | ||
| .filter { $0.kind == SwiftExpressionKind.argument.rawValue } |
There was a problem hiding this comment.
Use dictionary.enclosedArguments instead.
ornithocoder
changed the title
ornithocoder
changed the title
ornithocoder
changed the title
|
I'll keep this PR blocked for now because it depends on #1753. Once that one is merged, this one needs to be rebased and have the tests updated to match the correct number of lines. |
ornithocoder
changed the title
ornithocoder
force-pushed
the
issue_52
branch
2 times, most recently
from
c582bf2 to
d68cb1b
Compare
because closure bodies should not span too many lines. Implements realm#52.
It's easier to read than a long tuple.
ornithocoder
changed the title
|
Depends on #1750. |
because closure bodies should not span too many lines. Implements #52.