Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: don't use minSdkVersion set by app #1625

Merged
merged 1 commit into from
Sep 17, 2024
Merged

android: don't use minSdkVersion set by app #1625

merged 1 commit into from
Sep 17, 2024

Conversation

davidliu
Copy link
Collaborator

Client apps could set their minSdkVersion to a lower version (RN 0.73 defaults to 21, and RN 0.74 is at 23), unknowingly sidestepping the minSdkVersion restriction.

They can still explicitly override it by adding the following to their app's AndroidManifest.xml:

<uses-sdk tools:overrideLibrary="com.oney.WebRTCModule"/>

@davidliu davidliu marked this pull request as ready for review September 16, 2024 13:51
saghul
saghul approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@davidliu davidliu merged commit 8bd5e0a into master Sep 17, 2024
3 checks passed
@davidliu davidliu deleted the dl/fix_android_min_sdk_version branch September 17, 2024 03:48
santhoshvai pushed a commit to GetStream/react-native-webrtc that referenced this pull request Sep 17, 2024
@davidliu @santhoshvai
android: don't use minSdkVersion set by app (react-native-webrtc#1625)
fe6fe87
santhoshvai pushed a commit to GetStream/react-native-webrtc that referenced this pull request Oct 15, 2024
@davidliu @santhoshvai
android: don't use minSdkVersion set by app (react-native-webrtc#1625)
96cf7e5
davidliu added a commit to livekit/react-native-webrtc that referenced this pull request Dec 16, 2024
@davidliu @mtdxc @saghul
Merge upstream from commit 996c128 (#24)
f132492 
* ios: add support for external cameras on iPad

* ci: remove flipper from gumtestapp (react-native-webrtc#1608)

These were causing build errors recently, and were generally unneeded anyways.

* pc: align createDataChannel with standard

- Throw TypeError if no argument passed
- Stringify the label

Fixes: react-native-webrtc#1605

* android: report actual size in camera MediaStreamTrack settings (react-native-webrtc#1598)

* ios: fix exception in iOS 17+ w/ Xcode 15.4

* android: remove no longer used replace rule from manifest (react-native-webrtc#1609)

* sender: fix serializing RTCRtpSendParameters

It's possible for user code to replace encodings entirely. Thus, the
resulting array will not have RTCRtpEncodingParameters object instances,
but plain objects.

Handle it by deep-cloning the objects with JSON.parse(JSON.stringify(x))
since that will take care of appropriately serializing them, no matter
the type.

* misc: make serialization more resilient

Don't directly call toJSON, but rather rely on JSON serialization to do
it when cloning.

* release 124.0.4

89557ca misc: make serialization more resilient  ( Saúl Ibarra Corretgé 2024-08-14 11:53:32 +0200)
6cfedd7 sender: fix serializing RTCRtpSendParameters  ( Saúl Ibarra Corretgé 2024-08-14 11:11:08 +0200)
ac7f578 android: remove no longer used replace rule from manifest (react-native-webrtc#1609)  ( Saúl Ibarra Corretgé 2024-08-07 17:17:03 +0200)
f6667c8 ios: fix exception in iOS 17+ w/ Xcode 15.4  ( mtdxc 2024-08-07 17:22:10 +0800)
4c34ae1 android: report actual size in camera MediaStreamTrack settings (react-native-webrtc#1598)  ( davidliu 2024-08-07 17:56:57 +0900)
fb02a5b pc: align createDataChannel with standard  ( Saúl Ibarra Corretgé 2024-08-06 15:28:24 +0200)
c0ddefd ci: remove flipper from gumtestapp (react-native-webrtc#1608)  ( davidliu 2024-08-07 16:00:01 +0900)
a1bb18a ios: add support for external cameras on iPad  ( mtdxc 2024-07-10 20:25:23 +0800)

* ios: Add RTCAudioSession helper methods needed for CallKit (react-native-webrtc#1614)

* ios,android: add device/groupId to MediaStreamTrack.getSettings and implement applyConstraints (react-native-webrtc#1615)

* android: don't use minSdkVersion set by app (react-native-webrtc#1625)

* doc: remove duplicate / confusing information about screen-sharing (react-native-webrtc#1645)

* ios: add background camera access option

* ios: picture in picture implementation

---------

Co-authored-by: mtdxc <[email protected]>
Co-authored-by: Saúl Ibarra Corretgé <[email protected]>
Co-authored-by: Saúl Ibarra Corretgé <[email protected]>
saghul added a commit that referenced this pull request Jan 7, 2025
@saghul
release 124.0.5
803e720 
359caea android: document how to set audio category to media  ( Saba 2025-01-04 10:01:46 +0100)
036e374 android: add libwebrtc consumer proguard rules  ( davidliu 2024-12-20 23:23:52 +0900)
996c128 ios: picture in picture implementation  ( davidliu 2024-12-13 21:59:33 +0900)
b62727a ios: add background camera access option  ( davidliu 2024-12-02 04:44:14 -0800)
4f337cd doc: remove duplicate / confusing information about screen-sharing (#1645)  ( Saúl Ibarra Corretgé 2024-11-04 13:07:11 +0100)
8bd5e0a android: don't use minSdkVersion set by app (#1625)  ( davidliu 2024-09-17 12:47:59 +0900)
f3f3301 ios,android: add device/groupId to MediaStreamTrack.getSettings and implement applyConstraints (#1615)  ( davidliu 2024-08-26 17:50:58 +0900)
609c0b5 ios: Add RTCAudioSession helper methods needed for CallKit (#1614)  ( davidliu 2024-08-16 13:51:28 +0900)
AbdulBsit pushed a commit to AbdulBsit/react-native-webrtc that referenced this pull request Feb 6, 2025
@davidliu @AbdulBsit
android: don't use minSdkVersion set by app (react-native-webrtc#1625)
ecaeba4
AbdulBsit pushed a commit to AbdulBsit/react-native-webrtc that referenced this pull request Feb 6, 2025
@saghul @AbdulBsit
release 124.0.5
ac3b2f8 
359caea android: document how to set audio category to media  ( Saba 2025-01-04 10:01:46 +0100)
036e374 android: add libwebrtc consumer proguard rules  ( davidliu 2024-12-20 23:23:52 +0900)
996c128 ios: picture in picture implementation  ( davidliu 2024-12-13 21:59:33 +0900)
b62727a ios: add background camera access option  ( davidliu 2024-12-02 04:44:14 -0800)
4f337cd doc: remove duplicate / confusing information about screen-sharing (react-native-webrtc#1645)  ( Saúl Ibarra Corretgé 2024-11-04 13:07:11 +0100)
8bd5e0a android: don't use minSdkVersion set by app (react-native-webrtc#1625)  ( davidliu 2024-09-17 12:47:59 +0900)
f3f3301 ios,android: add device/groupId to MediaStreamTrack.getSettings and implement applyConstraints (react-native-webrtc#1615)  ( davidliu 2024-08-26 17:50:58 +0900)
609c0b5 ios: Add RTCAudioSession helper methods needed for CallKit (react-native-webrtc#1614)  ( davidliu 2024-08-16 13:51:28 +0900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saghul saghul saghul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidliu @saghul