Skip to content

fix: autolinking.json breaks whenever console.log is added to react-native.config.js #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: autolinking.json breaks whenever console.log is added to react-native.config.js #2679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 61 additions & 8 deletions packages/cli-config/src/readConfigFromDisk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,35 @@ const searchPlacesForCJS = [
];
const searchPlaces = [...searchPlacesForCJS, 'react-native.config.mjs'];

/**
* Suppress console output temporarily to prevent config file logs from appearing
*/
function suppressConsole() {
const originalMethods = {
log: console.log,
warn: console.warn,
error: console.error,
info: console.info,
debug: console.debug,
};

// Override console methods with empty functions
console.log = () => {};
console.warn = () => {};
console.error = () => {};
console.info = () => {};
console.debug = () => {};

return () => {
// Restore original console methods
console.log = originalMethods.log;
console.warn = originalMethods.warn;
console.error = originalMethods.error;
console.info = originalMethods.info;
console.debug = originalMethods.debug;
};
}

function parseUserConfig(searchResult: CosmiconfigResult): UserConfig {
const config = searchResult ? searchResult.config : undefined;
const result = schema.projectConfig.validate(config);
Expand All @@ -45,8 +74,14 @@ export async function readConfigFromDiskAsync(
searchPlaces,
});

const searchResult = await explorer.search(rootFolder);
return parseUserConfig(searchResult);
// Suppress console output during config loading
const restoreConsole = suppressConsole();
try {
const searchResult = await explorer.search(rootFolder);
return parseUserConfig(searchResult);
} finally {
restoreConsole();
}
}

/**
Expand All @@ -60,8 +95,14 @@ export function readConfigFromDisk(rootFolder: string): UserConfig {
searchPlaces: searchPlacesForCJS,
});

const searchResult = explorer.search(rootFolder);
return parseUserConfig(searchResult);
// Suppress console output during config loading
const restoreConsole = suppressConsole();
try {
const searchResult = explorer.search(rootFolder);
return parseUserConfig(searchResult);
} finally {
restoreConsole();
}
}

function parseDependencyConfig(
Expand Down Expand Up @@ -102,8 +143,14 @@ export async function readDependencyConfigFromDiskAsync(
searchPlaces,
});

const searchResult = await explorer.search(rootFolder);
return parseDependencyConfig(dependencyName, searchResult);
// Suppress console output during config loading
const restoreConsole = suppressConsole();
try {
const searchResult = await explorer.search(rootFolder);
return parseDependencyConfig(dependencyName, searchResult);
} finally {
restoreConsole();
}
}

/**
Expand All @@ -120,8 +167,14 @@ export function readDependencyConfigFromDisk(
searchPlaces: searchPlacesForCJS,
});

const searchResult = explorer.search(rootFolder);
return parseDependencyConfig(dependencyName, searchResult);
// Suppress console output during config loading
const restoreConsole = suppressConsole();
try {
const searchResult = explorer.search(rootFolder);
return parseDependencyConfig(dependencyName, searchResult);
} finally {
restoreConsole();
}
}

const emptyDependencyConfig = {
Expand Down