chore: remove unused native_modules files #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
requested review from
cipolleschi,
cortinico and
adamTrz
as code owners
github-actions
bot
added
docs
cortinico
approved these changes
Nov 5, 2024
| @@ -1,588 +0,0 @@ | |||
| import groovy.json.JsonSlurper | |||
There was a problem hiding this comment.
I was thinking instead of deleting this file we can just let it print a huge warning on what to do instead
There was a problem hiding this comment.
Oh that's very reasonable, will update
thymikee
commented
Nov 6, 2024
|
This is how warning messages look like for: Android (when running iOS (when running |
cortinico
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Native autolinking logic for iOS and Android moved to the core react-native repository with RN 0.75, which ties to RNC CLI v14.x:
These files should essentially be unused now in 0.75+ apps.
Test Plan:
Adjusted the documentation accordingly and removed the integration test for iOS autolinking.
Checklist