Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean command does not clean metro-cache on win32 #2161

Closed

Conversation

acoates-ms
Copy link
Contributor

Summary:

The fs.rm function on win32 does not expand 's, so the code to delete the metro cache using fs.rm('/metro-') does not delete anything on win32.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@thymikee
Copy link
Member

thymikee commented Nov 9, 2023

Hm, fs.rmSync on macOS also doesn't expand (I wouldn't expect that tbh), so this doesn't seem to be Windows related, and it looks like it doesn't work really for these -* cases

@TMisiukiewicz
Copy link
Collaborator

Hm, fs.rmSync on macOS also doesn't expand (I wouldn't expect that tbh), so this doesn't seem to be Windows related, and it looks like it doesn't work really for these -* cases

I tried it and seems you are right, I'd say we could skip the os check here

@TMisiukiewicz
Copy link
Collaborator

Tested this PR again with removed OS check - seems like it doesn't work on macOS. I'll look for a proper solution satisfying both systems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants