-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARKit image detection & Vertical Plane Detection #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@elderbas it's |
@elderbas I fixed the typo in the example in the Readme. I also tried to not give a value for planeDetection and it worked. I am not sure what went wrong, can you try to reproduce it and file an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image detection
Usage:
detectionImages
is an array of objects. Currently only images from assets are possible, but in future, we also want to enable images from filesystem, remote, etc.onAnchorDetected
,onAnchorUpdated
andonAnchorRemoved
is the more generic version ofonPlaneDetected
, etc. onAnchorDetected will notfiy about every anchor (plane and image currently).onPlane
-callbacks (position, positionAbsolute, eulerAngles, id)type
-property that specifies the type of the anchor (currentlyplane
andimage
)onPlane
-versions,onAnchor
won't notify about planes atm. but i will review this decision. I am unsure whether we should have aonXXXAnchor...
for every anchor type or just one genericonAnchor
-callback for every anchor type (i favour the later).onPlaneUpdate
has been renamed toonPlaneUpdated
(more consistent)Vertical plane detection
Usage:
Will notify about vertical planes as well in
onPlaneDetected
. You can distinguish withplaneAnchor.alignment === ARKit.ARPlaneAnchorAlignment.Vertical