Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][cherry-pick] Example Gallery clean up #41750

Merged
merged 6 commits into from
Dec 21, 2023
Merged

[docs][cherry-pick] Example Gallery clean up #41750

merged 6 commits into from
Dec 21, 2023

Conversation

angelinalg
Copy link
Contributor

Cherry-picking for 2.9.0:

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

angelinalg and others added 5 commits December 8, 2023 12:50
@angelinalg @sven1977
[docs] [rllib] Remove outdated RLlib examples from the docs 1/N (ray-…
f909409 
…project#41472)

Removing outdated examples.
cc: @sven1977

Signed-off-by: angelinalg <[email protected]>

---------

Signed-off-by: angelinalg <[email protected]>
Co-authored-by: Sven Mika <[email protected]>
@angelinalg
[docs] [train] Example Gallery Train examples to be the same as the o…
e82aea7 
…nes on the Train Examples page (ray-project#41596)

The Example Gallery with the training tag selected generates more examples than is in the Train Examples page. Removing some mislabelled examples by removing the training tag. Adding in two missing examples:

templates/04_finetuning_llms_with_deepspeed/ (Fine-tuning Llama-2 models)
/train/examples/transformers/transformers_torch_trainer_basic

---------

Signed-off-by: angelinalg <[email protected]>
@angelinalg
[docs][data][core][tune] remove mention of Many Model Training (ray-p…
cf749fd 
…roject#41682)

After much discussion, we are removing the concept and examples associated with MMT. We had three different ways of running it (Core, Data, Tune). We no longer recommend Tune. Although this is a valid workload, the upkeep of the examples and docs outweigh the value, based on page views. When there is more traction on this type of use case, we can create a more up-to-date example.
@pcmoritz @richardliaw @matthewdeng

Signed-off-by: angelinalg <[email protected]>
@angelinalg
[docs] [data] remove Data Processing tag from sidenav and examples (r…
fd5af55 
…ay-project#41686)

After much discussion, the Data Processing tag is too general. Removing it from the Example Gallery.
cc: @amogkam @scottjlee @pcmoritz

Signed-off-by: angelinalg <[email protected]>
@angelinalg
[docs][serve] Fix subsection title hierarchy (ray-project#41746)
b397c96 
Subsections are appearing in the Serve Examples page as separate docs vs sections of the Streaming doc.

Signed-off-by: angelinalg <[email protected]>
@angelinalg angelinalg added docs An issue or change related to documentation v2.9.0-pick labels Dec 8, 2023
@angelinalg angelinalg changed the title Cp 2.9.0 [docs][cherry-pick] Example Gallery clean up Dec 8, 2023
@architkulkarni architkulkarni self-assigned this Dec 8, 2023
@zhe-thoughts
Copy link
Collaborator

Is it OK to pick this after we build the wheel? This is just me being over cautious about having the wheel on time

@architkulkarni
Copy link
Contributor

If all the changes were in doc I think it would be okay to merge after the final wheel build. But this PR has changes outside of doc, and it even looks like an RLlib unit test is modified. So it might be better to merge it before. (Assuming the unit test passes)

@architkulkarni architkulkarni added the release-blocker P0 Issue that blocks the release label Dec 8, 2023
@angelinalg
Copy link
Contributor Author

I believe the failing exploding-death-star tests were signed off by @sven1977 except for the exploding-death-star-rllib-contrib-qmix-tests. I presume this is also a flakey test. Could someone from RLlib confirm?

sven1977
sven1977 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@sven1977 sven1977 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from RLlib perspective.
Thanks for this PR @angelinalg !

zhe-thoughts
zhe-thoughts approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@zhe-thoughts zhe-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but @architkulkarni if possible let's pick after we are able to have a green wheel without this PR (that we can easily go back to)

@architkulkarni
Copy link
Contributor

Sounds good. Everything looks good, will merge after we have the first "green commit" on the release branch

@architkulkarni architkulkarni merged commit 932eed0 into ray-project:releases/2.9.0 Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 sven1977 approved these changes

@zhe-thoughts zhe-thoughts zhe-thoughts approved these changes

@edoakes edoakes Awaiting requested review from edoakes edoakes is a code owner

@shrekris-anyscale shrekris-anyscale Awaiting requested review from shrekris-anyscale shrekris-anyscale is a code owner

@sihanwang41 sihanwang41 Awaiting requested review from sihanwang41 sihanwang41 is a code owner

@zcin zcin Awaiting requested review from zcin zcin is a code owner

@architkulkarni architkulkarni Awaiting requested review from architkulkarni architkulkarni is a code owner

@richardliaw richardliaw Awaiting requested review from richardliaw richardliaw is a code owner

@krfricke krfricke Awaiting requested review from krfricke krfricke is a code owner

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010 xwjiang2010 is a code owner

@amogkam amogkam Awaiting requested review from amogkam amogkam is a code owner

@matthewdeng matthewdeng Awaiting requested review from matthewdeng matthewdeng is a code owner

@Yard1 Yard1 Awaiting requested review from Yard1 Yard1 is a code owner

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@justinvyu justinvyu Awaiting requested review from justinvyu justinvyu is a code owner

@woshiyyya woshiyyya Awaiting requested review from woshiyyya woshiyyya is a code owner

@avnishn avnishn Awaiting requested review from avnishn avnishn is a code owner

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst ArturNiederfahrenhorst is a code owner

@smorad smorad Awaiting requested review from smorad

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha kouroshHakha is a code owner

@ericl ericl Awaiting requested review from ericl ericl is a code owner

@scv119 scv119 Awaiting requested review from scv119 scv119 is a code owner

@c21 c21 Awaiting requested review from c21 c21 is a code owner

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@raulchen raulchen Awaiting requested review from raulchen raulchen is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@Zandew Zandew Awaiting requested review from Zandew Zandew is a code owner

Assignees

@architkulkarni architkulkarni

@zhe-thoughts zhe-thoughts

Labels
docs An issue or change related to documentation release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angelinalg @zhe-thoughts @architkulkarni @sven1977