Add python and rust bindings for Ivf-Pq #90
Conversation
benfred
added
improvement
| >>> distances, neighbors = ivf_pq.search(ivf_pq.SearchParams(), | ||
| ... index, dataset, | ||
| ... k) | ||
| >>> distances = cp.asarray(distances) |
There was a problem hiding this comment.
I think we can clean this up now too and maybe follow the semantics that have been successful in cuml- if a numpy array is passed in, a numpy array should be returned, etc...
cuml abstracts these conversations behind a "CumlArray" object. I suspect we should consider doing something similar for cuVS.
|
|
||
| Parameters | ||
| ---------- | ||
| search_params : SearchParams |
There was a problem hiding this comment.
Does this automatically to the ivf_pq.SearchParas in the docs? If not, we might want to fully-qualify these
There was a problem hiding this comment.
good point about the docs! We were missing the RST files for ivf-pq and bfknn, so it didn't show up at all =( - I've added those in.
For linking to the SearchParams struct - I had to update to :py:class:cuvs.neighbors.ivf_pq.SearchParams (like both add the fully qualified class name, and the py:class marker to create the hyper link) - but with that change we get a clickable link in the sphinx docs
|
/merge |
Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#90
No description provided.