Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kIsSingleSource to PairwiseDistanceEpilogueElementwise #485

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Add kIsSingleSource to PairwiseDistanceEpilogueElementwise #485

merged 2 commits into from
Nov 22, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Nov 21, 2024 •
edited
Loading

With raft having recently migrated to cutlass 3.5.1, this field is now required.

Also remove raft_cutlass from symbol exclusions.

@KyleFromNVIDIA
Add kIsSingleSource to PairwiseDistanceEpilogueElementwise
41bf83e 
With raft having recently migrated to cutlass 3.5.1, this field is
now required.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner November 21, 2024 17:16
@github-actions github-actions bot added the cpp label Nov 21, 2024
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Introduces a non-breaking change labels Nov 21, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

cc @jackkosaian

@KyleFromNVIDIA
Copy link
Contributor Author

We need to remove raft_cutlass from symbol exclusions. I have a commit that does this locally and will push it once this round of CI finishes.

@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner November 21, 2024 22:16
bdice
bdice approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KyleFromNVIDIA! Approving additional changes.

@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 710e9f5 into rapidsai:branch-24.12 Nov 22, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice bdice approved these changes

@lowener lowener lowener approved these changes

@jameslamb jameslamb Awaiting requested review from jameslamb jameslamb is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees
No one assigned
Labels
bug Something isn't working cpp non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleFromNVIDIA @vyasr @bdice @lowener