-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and Package cuvs_bench
in CI
#367
Conversation
I see some c++-level cusolver include build errors in the Python package. |
/merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but please update the copyright for new files to only the current year. The changes here look good.
@@ -0,0 +1,65 @@ | |||
# ============================================================================= | |||
# Copyright (c) 2023-2024, NVIDIA CORPORATION. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use only current year for all new files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, Divye. I noticed in your other PR that there are many places RAFT still needs to be change dto cuVS. I can't approve this yet. However, these should be minor and simple changes to make. Shall we use your other PR going forward and close this one to make things more manageable?
@@ -37,10 +37,12 @@ HELP="$0 [<target> ...] [<flag> ...] [--cmake-args=\"<args>\"] [--cache-tool=<to | |||
-n - no install step | |||
--uninstall - uninstall files for specified targets which were built and installed prior | |||
--compile-static-lib - compile static library for all components | |||
--cpu-only - build CPU only components without CUDA. Currently only applies to bench-ann. | |||
--limit-tests - semicolon-separated list of test executables to compile (e.g. NEIGHBORS_TEST;CLUSTER_TEST) | |||
--limit-bench-ann - semicolon-separated list of ann benchmark executables to compute (e.g. HNSWLIB_ANN_BENCH;RAFT_IVF_PQ_ANN_BENCH) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RAFT needs to be changed to cuVS everywhere.
Approving, should be fine to merge once the RAFT/cuVS name changes are figured out. |
Closing for now because changes are in #368. Please open back up if this is absolutely neeed. |
Builds upon #367 Authors: - Divye Gala (https://github.com/divyegala) - Dante Gama Dessavre (https://github.com/dantegd) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Bradley Dice (https://github.com/bdice) URL: #368
This PR sets up building and packaging of
cuvs_bench
in CI, which will automatically setup publishing ofcuvs_bench
packages to rapids conda channels