Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and Package cuvs_bench in CI #367

Closed
wants to merge 21 commits into from

Conversation

divyegala
Copy link
Member

This PR sets up building and packaging of cuvs_bench in CI, which will automatically setup publishing of cuvs_bench packages to rapids conda channels

@divyegala divyegala added feature request New feature or request non-breaking Introduces a non-breaking change labels Oct 1, 2024
@divyegala divyegala requested review from a team as code owners October 1, 2024 19:04
@divyegala divyegala requested a review from AyodeAwe October 1, 2024 19:04
@github-actions github-actions bot added the ci label Oct 1, 2024
@divyegala divyegala requested a review from a team as a code owner October 2, 2024 00:29
@dantegd dantegd requested a review from a team as a code owner October 2, 2024 00:58
@github-actions github-actions bot added the Python label Oct 2, 2024
@cjnolet
Copy link
Member

cjnolet commented Oct 2, 2024

I see some c++-level cusolver include build errors in the Python package.

@cjnolet
Copy link
Member

cjnolet commented Oct 3, 2024

/merge

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please update the copyright for new files to only the current year. The changes here look good.

@@ -0,0 +1,65 @@
# =============================================================================
# Copyright (c) 2023-2024, NVIDIA CORPORATION.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use only current year for all new files.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Divye. I noticed in your other PR that there are many places RAFT still needs to be change dto cuVS. I can't approve this yet. However, these should be minor and simple changes to make. Shall we use your other PR going forward and close this one to make things more manageable?

@@ -37,10 +37,12 @@ HELP="$0 [<target> ...] [<flag> ...] [--cmake-args=\"<args>\"] [--cache-tool=<to
-n - no install step
--uninstall - uninstall files for specified targets which were built and installed prior
--compile-static-lib - compile static library for all components
--cpu-only - build CPU only components without CUDA. Currently only applies to bench-ann.
--limit-tests - semicolon-separated list of test executables to compile (e.g. NEIGHBORS_TEST;CLUSTER_TEST)
--limit-bench-ann - semicolon-separated list of ann benchmark executables to compute (e.g. HNSWLIB_ANN_BENCH;RAFT_IVF_PQ_ANN_BENCH)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAFT needs to be changed to cuVS everywhere.

@bdice
Copy link
Contributor

bdice commented Oct 3, 2024

Approving, should be fine to merge once the RAFT/cuVS name changes are figured out.

@cjnolet
Copy link
Member

cjnolet commented Oct 3, 2024

Closing for now because changes are in #368. Please open back up if this is absolutely neeed.

@cjnolet cjnolet closed this Oct 3, 2024
rapids-bot bot pushed a commit that referenced this pull request Oct 4, 2024
Builds upon #367

Authors:
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Bradley Dice (https://github.com/bdice)

URL: #368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake cpp feature request New feature or request non-breaking Introduces a non-breaking change Python
Projects
Development

Successfully merging this pull request may close these issues.

5 participants