-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info to ANN_BENCH context #248
Add more info to ANN_BENCH context #248
Conversation
I'm thinking whether we should include some environment variables if present or the machine hostname? Wouldn't that be a bit fishy in terms of user privacy when sharing the output files? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Artem, LGTM, it is useful to extend the context information. I do not see any issues with adding the hostname.
For env vars, I am not sure what would be relevant. |
We could get the openmp-related env vars to see if the limit to the number of threads is set explicitly. |
/merge |
Add extra information to benchmark context for better reproducibility and performance analysis: 1. Full command line used to call the executable (so you can copy-paste and run again). 2. More CUDA device information: whether HMM, AST, or host atomics are available (how GPU can efficiently communicate with CPU). 3. Host information: min/max frequences, used virtual processors and cores, available physical memory and swap (does the benchmark segfault due to not enough host memory? is SMT enabled? etc). Addresses parts of rapidsai#160 Authors: - Artem M. Chirkin (https://github.com/achirkin) Approvers: - Tamas Bela Feher (https://github.com/tfeher) URL: rapidsai#248
Add extra information to benchmark context for better reproducibility and performance analysis:
Addresses parts of #160