-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix root loggingref #5118
base: dev-v2.11
Are you sure you want to change the base?
Fix root loggingref #5118
Conversation
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
{{- $containerLogPath := printf "%s/containers/" (default "/var/lib/docker" .Values.global.dockerRootDirectory) }} | ||
metadata: | ||
name: "{{ .Release.Name }}-root" | ||
spec: | ||
{{- include "logging-operator.individualLoggingRef" (dict "loggingRef" .Values.additionalLoggingSources.loggingRef) | nindent 2 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also take a look the fluentbitagent.yaml under kube-audit, from my test, without a loggingRef
, the kube-audit
log is also sent to root-fluend
, thanks.
Harvester patches the pulled rancher-logging chart locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@w13915984028 You can set this thru below, and that's being set here: https://github.com/rancher/charts/blob/dev-v2.11/charts/rancher-logging/106.0.0-rc.1%2Bup4.10.0/templates/loggings/kube-audit/fluentbitagent.yaml#L2-L6
with the helper function https://github.com/rancher/charts/blob/dev-v2.11/charts/rancher-logging/106.0.0-rc.1%2Bup4.10.0/templates/_helpers.tpl#L220
additionalLoggingSources:
kube-audit:
enabled: true
loggingRef: kubeauditlogging
fluentbit:
loggingRef: kubeauditlogging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skanakal That's great, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya - if I understand, this helps fix a bug in logging that harvester team observed, but could affect other use cases. Is that correct? If so, can we instead have a PR to apply it to this charts package here: https://github.com/rancher/ob-team-charts/tree/main/packages/rancher-logging/4.10
Note: ob-team-charts
is essentially a repo setup the same way rancher-charts
is however it's the new source area for O&B team to maintain the rancher specific changes/fixes to Monitoring and Logging charts. Then our team will sync charts from this repo into rancher/charts
.
Pull Requests Rules
Never remove an already released chart!
Each Pull Request should only modify one chart with its dependencies.
Pull request title:
<action>
: 1 of (bump; remove; UnRC)Checkpoints for Chart Bumps
release.yaml
:Chart.yaml and index.yaml
:index.yaml
file has an entry for your new chart version.index.yaml
entries for each chart matches theChart.yaml
for each chart.Fill the following only if required by your manager.
Issue:
rancher/rancher#49057
Solution
allow root logging to inherit loggingRef from values.yaml, ensuring it behaves like other logging sources...
QA Testing Considerations