Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo_structure update for Directories as Environment #24

Closed

Conversation

tchia04
Copy link

@tchia04 tchia04 commented Dec 22, 2018

Removing the dev env file from the prod folder and the prod env file from the dev folder for

Directories as Environment
Directories as Environments with a Single Module

It's confusing to see "prod-us-west-2.env" under the dev folder and "dev-us-west-2.env" under the prod folder.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Removing the dev env file from the prod folder and the prod env file from the dev folder.
@troyready
Copy link
Contributor

@tchia04 thanks a ton for you contribution here, and my apologies for not getting back to you sooner. I've been meaning to write up some more information about this for some time.

I just pushed an update to the docs explaining the reasoning a bit more. I hope the current version explains it better now, but of course feel free to submit another PR if have ideas on how to improve it.

@troyready troyready closed this Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants