Skip to content

feat(nodejs): custom logging #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 5, 2023
Merged

feat(nodejs): custom logging #15

merged 5 commits into from
Jan 5, 2023

Conversation

glasstiger
Copy link
Collaborator

@glasstiger glasstiger commented Jan 4, 2023

Extended the options of the client with a new property: log.
Now the host application can pass a logging function to the client.

log: (level: 'error'|'warn'|'info'|'debug', message: string) => void

If this property not provided, default logging is used which writes to the console with logging level info.

@glasstiger glasstiger marked this pull request as draft January 4, 2023 16:39
@glasstiger glasstiger marked this pull request as ready for review January 4, 2023 17:49
@puzpuzpuz puzpuzpuz added the enhancement New feature or request label Jan 4, 2023
Copy link
Collaborator

@puzpuzpuz puzpuzpuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a couple minor comments.

@glasstiger glasstiger merged commit 83c7b19 into main Jan 5, 2023
@glasstiger glasstiger deleted the custom_logging branch January 5, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants