Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add resizing for QTable Columns: Issue #5115 #17838

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

TheMeanBeanMachine
Copy link

@TheMeanBeanMachine TheMeanBeanMachine commented Feb 17, 2025

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

Other information:
I am excited to submit this pull request, which introduces a feature that has been highly requested by the community, including myself. This is my first contribution to the project, and I have designed the component to be highly customizable to accommodate various use cases.

I welcome any feedback or suggestions for improvements, and I am open to making any necessary adjustments to ensure it aligns with the project's standards and goals.

Thank you for considering my contribution!

// Example Photos from test app used to verify functionality

image
image

Example table with one resizable column:
image

@TheMeanBeanMachine TheMeanBeanMachine changed the title ZE-0 Add resizing for QTable Columns: Issue #5115 feat: Add resizing for QTable Columns: Issue #5115 Feb 18, 2025
@TheMeanBeanMachine
Copy link
Author

Can I get a review on this please?

@pdanpdan
Copy link
Collaborator

You mixed

  • 4 space indent with the existing 2 space indent
  • options API with the existing composition API
  • semicolons in SASS

This change would also require to add the description of the added things in the API description JSON

If you want a review on code please change the PR so that it matches the existing code.

@TheMeanBeanMachine
Copy link
Author

I'll work on that thank you for the feedback :)

@TheMeanBeanMachine
Copy link
Author

TheMeanBeanMachine commented Feb 27, 2025

hey @pdanpdan sorry to ask but could you tell me where the api description json is?

So far i cleaned up most of what you wanted and added ability to use column definitions to specify which columns are resizable. Also made it so you can double click the grabbers to make the columns go back to their default size.

Still need to clean up code a bit and add the description of the new functionality to the api description json.

@pdanpdan
Copy link
Collaborator

https://github.com/quasarframework/quasar/blob/dev/ui/src/components/table/QTable.json

@TheMeanBeanMachine
Copy link
Author

@TheMeanBeanMachine TheMeanBeanMachine marked this pull request as draft February 28, 2025 00:23
@TheMeanBeanMachine TheMeanBeanMachine marked this pull request as ready for review February 28, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants