feat(docs): add "copy to clipboard" to styles section #17782
+201
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default clipboard copy option for row names - Same style as .md table - Automatic apply badge to .md syntax: `some code` - Flexible for more columns
yusufkandemir
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Thanks, but we are using <script setup> in the docs code. You used Options API for the new things you added, and even converted the existing code to Options API. So, we can't accept this as is.
If you could convert it to <script setup>, that would be nice. Otherwise, we either have to:
- need more time to do it ourselves
- wait for someone else to create a similar PR
- deny the PR
yusufkandemir
changed the title
Thx for the feedback! I’ve updated the code to use <script setup> as requested. Let me know if there’s anything else that needs adjustment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
devbranch (orv[X]branch)fix: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
I'm always using the "Style and Identity" document tab to grab some class names. But, I have to copy them manually.
The initial purpose of this change is just to add a copy to clipboard option. But along the way, I created a table component to make it easier for all tables to have this functionality.