feat!: add GraphQL subscriptions support #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json and the committed lockfile is out of sync
The downside is now we have to sync them manually. But, the major advantage is that we can now use templating logic inside the TS template. Following commits will utilize that.
drop support for deprecated q/app
it turned out it was previously coming from q/app, but we removed q/app so it's no longer there
the next step is making the deps optional
IlCallo
reviewed
Sep 18, 2023
src/templates/.eslintrc.js
Outdated
|
|
||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:lodash-template/recommended-with-script' |
There was a problem hiding this comment.
It seems like you're not adding this into any plugins array, may this be the problem
There was a problem hiding this comment.
It's not needed as the config adds the plugin automatically:
https://github.com/ota-meshi/eslint-plugin-lodash-template/blob/d1e00964657a8b67ebfdd8269a74628d078d3f3c/lib/configs/base.js#L7
Co-authored-by: Paolo Caleffi <[email protected]>
Co-authored-by: Paolo Caleffi <[email protected]>
…encies Co-authored-by: Paolo Caleffi <[email protected]>
IlCallo
approved these changes
Sep 18, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #104.
Breaking Change: Dropped support for
@quasar/appv3. Dropping it made it easier to apply some fixes and it's deprecated:Previously, we used TS files as the source for the template files, then built it to create JS versions of the templates. However, this makes it harder to use Lodash templating inside code. We would need first to render the template, and then build the JS files off of the generated TS file. I updated the structure to eliminate the TS build step. We now have JS and TS templates separately, so they need to be synced manually if needed. We use this approach in Quasar core code and in testing AEs as well.
I also improved the linting setup. There are some limitations/problems, which probably need to be resolved at https://github.com/ota-meshi/eslint-plugin-lodash-template. I will report those problems later.