Map tool idenfify: Add support for index in mesh data #60896
+285
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitjano
force-pushed
the
mesh-closest-element
branch
3 times, most recently
from
d595836 to
d522b8a
Compare
This is a generalization of `snapOnElement`, since it allows to also get the element (face, vertex or edge) index.
This is achieved by using `QgsMeshLayer::closestElement()` instead of `QgsMeshLayer::snapOnElement()`.
ptitjano
force-pushed
the
mesh-closest-element
branch
from
d522b8a to
3259f79
Compare
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
nyalldawson
reviewed
Mar 11, 2025
| * | ||
| * \since QGIS 3.44 | ||
| */ | ||
| int closestElement( QgsMesh::ElementType elementType, const QgsPointXY &point, double searchRadius, QgsPointXY &projectedPoint ) const; |
There was a problem hiding this comment.
Suggested change
| int closestElement( QgsMesh::ElementType elementType, const QgsPointXY &point, double searchRadius, QgsPointXY &projectedPoint ) const; | |
| int closestElement( QgsMesh::ElementType elementType, const QgsPointXY &point, double searchRadius, QgsPointXY &projectedPoint SIP_OUT ) const; |
| @@ -925,38 +926,16 @@ int QgsMeshLayer::closestEdge( const QgsPointXY &point, double searchRadius, Qgs | |||
| return selectedIndex; | |||
| } | |||
|
|
|||
| QgsMeshDatasetIndex QgsMeshLayer::staticVectorDatasetIndex( int group ) const | |||
There was a problem hiding this comment.
Why move this code? It clutters the diff here, and will make git blame a bit more frustrating...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This extends the identify tool to also display the index of a vertex/face/edge of a mesh.
See, the screenshot below: