Update sphinx to 3.5.4 #4318
Merged
Update sphinx to 3.5.4 #4318
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine, we can merge it. Type annotation rendering was the main issue, now it's OK: https://747909-73328905-gh.circle-artifacts.com/0/docs/datasets.html |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
Reviewed By: fmassa Differential Revision: D30793339 fbshipit-source-id: f2daaf6626f46bc2fa5aaa46fd71f539b93b5836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that pytorch/pytorch_sphinx_theme#115 is fixed we should be able to update sphinx.
Making this is draft for now as I need to properly check the rendered docs