(torchx/components) pass --tee=3 to dist.ddp to prefix local_rank on the worker's stdout and stderr streams #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the worker's stdout and stderr streams Summary: Addresses the QOL issue around SLURM logs mentioned in #405 TL;DR - since torchx launches nodes (not tasks) in SLURM, the stdout and stderr logs are combined for all 8 workers on the node (versus having separate ones for each worker when launched as task). This makes `dist.ddp` set `--tee=3` flag to torchelastic which prefixes each line of stderr and stdout of the workers with the local_rank of that worker so that the user can easily grep out the logs for a particular worker. Differential Revision: D34726681 fbshipit-source-id: 24500a68981db7671f2f57961cc7dfa96c8a45e8
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34726681 |
9 tasks
Codecov Report
@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 66 66
Lines 3685 3685
=======================================
Hits 3472 3472
Misses 213 213
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addresses the QOL issue around SLURM logs mentioned in #405
TL;DR - since torchx launches nodes (not tasks) in SLURM, the stdout and stderr logs are combined for all 8 workers on the node (versus having separate ones for each worker when launched as task). This makes
dist.ddpset--tee=3flag to torchelastic which prefixes each line of stderr and stdout of the workers with the local_rank of that worker so that the user can easily grep out the logs for a particular worker.Differential Revision: D34726681