(torchx/components) expose raw resource params for dist.ddp #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Exposes raw resources (cpu, gpu, memMB) in addition to "host" (named resource) for dist.ddp and utils.python to make it convenient for users who don't want to register named resources in entrypoint. Reviewed By: aivanou Differential Revision: D34260962 fbshipit-source-id: 3d9db25b60b0a3aef5a0ecf5962f20d68d776afe
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34260962 |
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
==========================================
+ Coverage 93.14% 93.18% +0.04%
==========================================
Files 66 66
Lines 3544 3551 +7
==========================================
+ Hits 3301 3309 +8
+ Misses 243 242 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Exposes raw resources (cpu, gpu, memMB) in addition to "host" (named resource) for dist.ddp and utils.python to make it convenient for users who don't want to register named resources in entrypoint.
Reviewed By: aivanou
Differential Revision: D34260962