VideoStreamMetadata.sample_aspect_ratio: new metadata field (#733) #737
+33
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New field to
VideoStreamMetadata
to at least get information about the stream sample/pixel aspect ratio. Getting this information is the minimum required to support non-square pixels.This addresses issue #733 (which was deemed "reasonable" which is why I'm implementing it, thank you for considering this).
There is one thing that annoys me about this PR. The names for properties in C++
StreamMetadata
and json returned byget_stream_json_metadata
match. I could have separate num/den properties inStreamMetadata
but I don't think that's quite right because they're actually two parts of the same value. On the json side of things I made it two separate properties because it'sstd::map<std::string, std::string>
(although it would be trivial to make it a colon separated string and parse it on the python side of things).