Add ability to enable/disable linux_job_v2 workflow calls #6309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jithunnair-amd
force-pushed
the
enable_linux_job_v2
branch
from
640c2b5 to
e2df1bb
Compare
|
I have a comment on https://github.com/pytorch/ao/pull/1581/files#r1964465401 to see if this is really needed. This doesn't seem like a good idea to have this custom flag here to sever just this case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to pytorch/ao#1581
Helps to enable/disable specific entries of a matrix that are all invoking linux_job_v2.yml. In the case of the torchao PR above, we want to disable only the ROCm entry of the matrix when the workflow runs on torchao PRs.
Example of successful disable using this PR logic: https://github.com/pytorch/ao/actions/runs/13444026734/workflow