This repository was archived by the owner on Jul 1, 2023. It is now read-only.
Fix libnop headers being private in CMake #206
Closed
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beauby
approved these changes
Sep 4, 2020
| @@ -17,7 +17,8 @@ namespace channel { | |||
| Channel::TDescriptor saveDescriptor(const AbstractNopHolder& object) { | |||
| const size_t len = object.getSize(); | |||
| Channel::TDescriptor out(len, '\0'); | |||
| NopWriter writer(reinterpret_cast<uint8_t*>(out.data()), len); | |||
| NopWriter writer( | |||
| const_cast<uint8_t*>(reinterpret_cast<const uint8_t*>(out.data())), len); | |||
There was a problem hiding this comment.
You could also use reinterpret_cast<uint8_t*>(&out[0]).
There was a problem hiding this comment.
@lw has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
lw
added a commit
that referenced
this pull request
Sep 20, 2021
Summary: And a missing const_cast Pull Request resolved: #206 Reviewed By: beauby Differential Revision: D23540899 Pulled By: lw fbshipit-source-id: d97bbbfa541f8598aa351c9701b2507e3f7759a0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And a missing const_cast