Skip to content

Update header and footer to match new site design #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cjyabraham
Copy link

@cjyabraham cjyabraham commented May 8, 2025

This repeats work from this PR to adapt to the new docs theme, bringing it in to alignment with the new PyTorch redesign.

Header now looks like this:

Screenshot 2025-05-10 at 12 38 05 PM

And footer looks like this:

Screenshot 2025-05-10 at 12 40 10 PM
Screenshot 2025-05-10 at 12 40 01 PM

A few notes:

  • I tweaked the color of $pytorch-red to match what's on the live site. Note this color was chosen so that it meets WCAG AA accessibility contrast requirements. The original color does not.
  • The footer social icons don't exactly match the live site, however, I think they're close enough and look a bit sharper than the live site.

Signed-off-by: Chris Abraham <[email protected]>
cjyabraham added 5 commits May 8, 2025 15:17
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
@cjyabraham cjyabraham marked this pull request as ready for review May 10, 2025 19:41
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, Chris!

@svekars svekars merged commit 17b2060 into pytorch:pytorch_sphinx_theme2 May 12, 2025
1 check passed
@cjyabraham cjyabraham deleted the pytorch_sphinx_theme2 branch May 13, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants