-
Notifications
You must be signed in to change notification settings - Fork 24k
Add bound method tests for async_execution with RRef helper #44716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit a5db816 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
codecov.io: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 8 times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "bound" here mean that the futures are chained?
I was referring to Python's terminology:
|
Differential Revision: [D23707326](https://our.internmc.facebook.com/intern/diff/D23707326) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/mrshenli/238/base #44716 +/- ##
=====================================================
Coverage 67.88% 67.89%
=====================================================
Files 384 384
Lines 49718 49724 +6
=====================================================
+ Hits 33752 33758 +6
Misses 15966 15966
Continue to review full report at Codecov.
|
Differential Revision: [D23707326](https://our.internmc.facebook.com/intern/diff/D23707326) [ghstack-poisoned]
Summary: Pull Request resolved: #44716 Test Plan: Imported from OSS Reviewed By: rohan-varma Differential Revision: D23707326 Pulled By: mrshenli fbshipit-source-id: a2f8db17447e9f82c9f6ed941ff1f8cb9090ad74
Stack from ghstack:
Differential Revision: D23707326