Skip to content

Add bound method tests for async_execution with RRef helper #44716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

mrshenli
Copy link
Contributor

@mrshenli mrshenli commented Sep 15, 2020

Stack from ghstack:

Differential Revision: D23707326

mrshenli added a commit that referenced this pull request Sep 15, 2020
@dr-ci
Copy link

dr-ci bot commented Sep 15, 2020

💊 CI failures summary and remediations

As of commit a5db816 (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

Extra GitHub checks: 1 failed


codecov.io: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 8 times.

Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "bound" here mean that the futures are chained?

@mrshenli
Copy link
Contributor Author

Does "bound" here mean that the futures are chained?

I was referring to Python's terminology:

>>> class Test:
...   def f(self):
...     pass
... 
>>> t = Test()
>>> t.f
<bound method Test.f of <__main__.Test object at 0x7f06a08f8610>>

mrshenli added a commit that referenced this pull request Sep 16, 2020
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #44716 into gh/mrshenli/238/base will increase coverage by 0.00%.
The diff coverage is 28.57%.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           gh/mrshenli/238/base   #44716   +/-   ##
=====================================================
  Coverage                 67.88%   67.89%           
=====================================================
  Files                       384      384           
  Lines                     49718    49724    +6     
=====================================================
+ Hits                      33752    33758    +6     
  Misses                    15966    15966           
Impacted Files Coverage Δ
torch/distributed/rpc/functions.py 85.71% <ø> (ø)
...orch/testing/_internal/distributed/rpc/rpc_test.py 25.69% <28.57%> (+0.01%) ⬆️
torch/utils/_benchmark/utils/timer.py 90.12% <0.00%> (+1.23%) ⬆️
torch/utils/_benchmark/utils/common.py 80.16% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7989ef...a5db816. Read the comment docs.

mrshenli added a commit that referenced this pull request Sep 16, 2020
@facebook-github-bot
Copy link
Contributor

@mrshenli merged this pull request in cce7680.

xuzhao9 pushed a commit that referenced this pull request Sep 18, 2020
Summary: Pull Request resolved: #44716

Test Plan: Imported from OSS

Reviewed By: rohan-varma

Differential Revision: D23707326

Pulled By: mrshenli

fbshipit-source-id: a2f8db17447e9f82c9f6ed941ff1f8cb9090ad74
@facebook-github-bot facebook-github-bot deleted the gh/mrshenli/238/head branch September 20, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants